[webkit-reviews] review granted: [Bug 134919] Decrease flicker when enter and exit fullscreen. : [Attachment 234908] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 134919: Decrease flicker when enter and exit fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=134919

Attachment 234908: Patch
https://bugs.webkit.org/attachment.cgi?id=234908&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234908&action=review


> Source/WebCore/ChangeLog:9
> +	   is as easy as adding and removig it from a containter layer; no need
to do a layout.

removig

> Source/WebCore/ChangeLog:11
> +	   Make sure fullscreen layers are transpreant before moving moving the
AVPlayerLayer

transpreant

> Source/WebKit2/ChangeLog:8
> +	   Change the sequence of teartdown and use transparency to prevent
flicker when entering and exiting fullscreen.

teartdown

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:89
> + at interface WebVideoContainerLayer : CALayer { }

I don't think you need the { }

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:93
> +-(void)setBounds:(CGRect)bounds {

Space after the @implementation line. { on a new line.

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:96
> +    for (CALayer* l in self.sublayers)
> +	   l.frame = bounds;

Please don't abbreviate layer to l.

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:624
>      m_videoLayer = 0;
> +    m_videoInlineLayer = 0;

These should be nil

> Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm:181
> + at interface WebVideoContainerLayer : CALayer
> + at end

Nor should this.

> Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm:36
> +#import <WebCore/WAKWindow.h>

Why this?