[webkit-reviews] review requested: [Bug 133796] ASSERT_NOT_REACHED() in WebCore::fontWeightIsBold : [Attachment 234912] Patch v2

[bugzilla-daemon at webkit.org]

Tibor Mészáros <tmeszaros.u-szeged at partner.samsung.com> has asked  for review:
Bug 133796: ASSERT_NOT_REACHED() in WebCore::fontWeightIsBold
https://bugs.webkit.org/show_bug.cgi?id=133796

Attachment 234912: Patch v2
https://bugs.webkit.org/attachment.cgi?id=234912&action=review

------- Additional Comments from Tibor Mészáros
<tmeszaros.u-szeged at partner.samsung.com>
    Source/WebCore/editing/EditingStyle.cpp:1516
    static bool fontWeightIsBold(CSSValue* fontWeight)

Is now CSSValue&.

    Source/WebCore/editing/EditingStyle.cpp:1551
    +static bool fontWeightNeedsResolving(CSSValue* fontWeight)

Is now CSSValue&.

    Source/WebCore/editing/EditingStyle.cpp:1574
    + if (RefPtr<CSSValue> baseFontWeight = extractPropertyValue(baseStyle,
CSSPropertyFontWeight)) {
    + if (RefPtr<CSSValue> fontWeight =
mutableStyle->getPropertyCSSValue(CSSPropertyFontWeight)) {
    + if (!fontWeightNeedsResolving(fontWeight.get()) &&
(fontWeightIsBold(fontWeight.get()) fontWeightIsBold(baseFontWeight.get())))

Merged the upper three "If" into one

    Source/WebCore/editing/EditingStyle.cpp:1556
    + return !(value CSSValueLighter || value == CSSValueBolder);

I had put CSSValueLighter and CSSValueBolder into fontWeightIsBold. It will be
correct in the case where lighter still results in bolded text or bolder
resulting in "light" text.