[webkit-reviews] review granted: [Bug 134666] NetworkProcess sometimes hangs under copyDefaultCredentialForProtectionSpace : [Attachment 234841] Add SecAccessControlRef support to ArgumentCodersCF

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted mitz at webkit.org <mitz at webkit.org>'s
request for review:
Bug 134666: NetworkProcess sometimes hangs under
copyDefaultCredentialForProtectionSpace
https://bugs.webkit.org/show_bug.cgi?id=134666

Attachment 234841: Add SecAccessControlRef support to ArgumentCodersCF
https://bugs.webkit.org/attachment.cgi?id=234841&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234841&action=review


> Source/WebKit2/ChangeLog:11
> +	   by ArgumentCodersCF. In debug builds, trying to encode a
CFDictionary containing a value of
> +	   unsupprted type causes an assertion to fail, but in release builds
encoding succeeds, and
> +	   only decoding fails, in this case silently, simply not delivering
the

This seems like a pretty unfortunate failure mode...

> Source/WebKit2/Shared/cf/ArgumentCodersCF.cpp:731
> +    result = adoptCF(SecAccessControlCreateFromData(kCFAllocatorDefault,
data.get(), nullptr));

Do we know that these things are sufficiently safe to IPC as raw data?