[webkit-reviews] review granted: [Bug 134832] [GTK] Simplify make-dist command line arguments : [Attachment 234762] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 134832: [GTK] Simplify make-dist command line arguments
https://bugs.webkit.org/show_bug.cgi?id=134832

Attachment 234762: Patch
https://bugs.webkit.org/attachment.cgi?id=234762&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=234762&action=review


Looks good, but consider moving the code that calculate the current version.

> Tools/gtk/make-dist.py:303
> +	       pkgconfig_file = os.path.join(arguments.build_dir,
"Source/WebKit2/webkit2gtk-3.0.pc")
> +	       if os.path.isfile(pkgconfig_file):
> +		   p = subprocess.Popen(['pkg-config', '--modversion',
pkgconfig_file], stdout=subprocess.PIPE)
> +		   version = p.communicate()[0]
> +		   if version:
> +		       tarball_root += '-' + version.rstrip('\n')

Would it make sense to move to this after argument parsing so that other parts
of the code can use arguments.version safely in the future?