[webkit-reviews] review denied: [Bug 25571] DOM range methods setStartBefore/setEndAfter fails on detached elements : [Attachment 225142] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jul 12 16:52:56 PDT 2014


Darin Adler <darin at apple.com> has denied Bhanu <b.rout at samsung.com>'s request
for review:
Bug 25571: DOM range methods setStartBefore/setEndAfter fails on detached
elements
https://bugs.webkit.org/show_bug.cgi?id=25571

Attachment 225142: Patch
https://bugs.webkit.org/attachment.cgi?id=225142&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225142&action=review


review- because of Ryosuke’s comment

> Source/WebCore/ChangeLog:27
> +	   * dom/Range.h: added default value ASSERT_NO_EXCEPTION to exception
code in setStartBefore() method 
> +	   to avoid unwanted behavior due to uninitialized value.

I don’t understand what the uninitialized value issue is. Which call site has
this unwanted behavior due to an uninitialized value?


More information about the webkit-reviews mailing list