[webkit-reviews] review granted: [Bug 134828] Partition the CSS rules based on the most specific filter of the rightmost fragment : [Attachment 234748] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 11 16:27:15 PDT 2014


Andreas Kling <akling at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 134828: Partition the CSS rules based on the most specific filter of the
rightmost fragment
https://bugs.webkit.org/show_bug.cgi?id=134828

Attachment 234748: Patch
https://bugs.webkit.org/attachment.cgi?id=234748&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234748&action=review


Pretty clever! r=me

> Source/WebCore/css/RuleSet.cpp:218
> +	       } else {

This should be else if (classBucketSize)... since a completely empty class
bucket is strongly preferable.


More information about the webkit-reviews mailing list