[webkit-reviews] review granted: [Bug 134798] [iOS][WK2] Fix withinEpsilon() : [Attachment 234729] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 134798: [iOS][WK2] Fix withinEpsilon()
https://bugs.webkit.org/show_bug.cgi?id=134798

Attachment 234729: Patch
https://bugs.webkit.org/attachment.cgi?id=234729&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234729&action=review


> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:792
> +    return std::abs(a - b) < std::numeric_limits<float>::epsilon();

I still think a comment is needed here to explain why it’s float epsilon rather
than the epsilon for the type of the result of a - b.