[webkit-reviews] review denied: [Bug 134414] Web Inspector: Add a setting for clearing the console on page reload : [Attachment 234719] patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has denied Ronald <rjett at apple.com>'s
request for review:
Bug 134414: Web Inspector: Add a setting for clearing the console on page
reload
https://bugs.webkit.org/show_bug.cgi?id=134414

Attachment 234719: patch
https://bugs.webkit.org/attachment.cgi?id=234719&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234719&action=review


> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:113
>      get navigationItems()
>      {
> -	   return [this._searchBar, this._scopeBar,
this._clearLogNavigationItem, this._toggleSplitNavigationItem];
> +	   return [this._searchBar, this._scopeBar,
this._clearLogNavigationItem, this._clearLogOnReloadNavigationItem,
this._toggleSplitNavigationItem];

I don't think a navigation bar item is the right UI for this at this time. (We
would need a new icon that is not confusing with a general Reload.)

Lets add it to the context menu. You can do that in _handleContextMenuEvent by
using appendCheckboxItem. You should also do appendSeparator between the
existing Clear Log item.

> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:301
> +	   if (this._clearLogOnReloadSetting.value) {
> +	       this._clearLog();
> +	   }

WebKit style is to not use braces for single lines.