[webkit-reviews] review granted: [Bug 134651] Subpixel layout: return integral results for offset*, client*, scroll* by default. : [Attachment 234596] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 10 10:34:07 PDT 2014


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Zalan Bujtas
<zalan at apple.com>'s request for review:
Bug 134651: Subpixel layout: return integral results for offset*, client*,
scroll* by default.
https://bugs.webkit.org/show_bug.cgi?id=134651

Attachment 234596: Patch
https://bugs.webkit.org/attachment.cgi?id=234596&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234596&action=review


> Source/WebCore/dom/Element.cpp:767
> +	   double clientTop = subpixelMetricsEnabled(renderer->document()) ?
renderer->clientTop().toDouble() : roundToInt(renderer->clientTop());

double -> LayoutUnit for all of these.


More information about the webkit-reviews mailing list