[webkit-reviews] review granted: [Bug 134785] Web Inspector: Debugger Pause button does not work : [Attachment 234679] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 134785: Web Inspector: Debugger Pause button does not work
https://bugs.webkit.org/show_bug.cgi?id=134785

Attachment 234679: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=234679&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234679&action=review


> Source/JavaScriptCore/CMakeLists.txt:902
> +    COMMAND ${PERL_EXECUTABLE} -e 'print "//#
sourceURL=__WebInspectorInjectedScript__\n"' >
${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InjectedScriptSource.min.js

Is there is a better, shared, place to add this line? I guess the same question
applies to the rest of the build logic that is duplicated.

Maybe we can hack jsmin.py to not strip sourceURL? Likely not worth it though…

> Source/WebInspectorUI/ChangeLog:13
> +	   Now that we allow anonymous scripts we can step into anonymous

We have always allowed anon scripts. I think this was just an oversight with
the skipping code.

> Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js:-373
> -	   if (!this._callFrames.length) {
> -	       this.resume();
> -	       return;
> -	   }

I wonder how often this legitimately happens still.