[webkit-reviews] review granted: [Bug 134788] [iOS] Some QuickLook documents are not displayed as previews : [Attachment 234677] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 9 23:21:20 PDT 2014


Pratik Solanki <psolanki at apple.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 134788: [iOS] Some QuickLook documents are not displayed as previews
https://bugs.webkit.org/show_bug.cgi?id=134788

Attachment 234677: Patch
https://bugs.webkit.org/attachment.cgi?id=234677&action=review

------- Additional Comments from Pratik Solanki <psolanki at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234677&action=review


> Source/WebCore/ChangeLog:4
> +	   https://bugs.webkit.org/show_bug.cgi?id=134788

Mention the radar number here as well.

> Source/WebCore/ChangeLog:9
> +	   NSURLRequest have no way to set this bit properly) and should
probably be removed. Instead of using

That would be great! Do you think we can update all uses of
isMainResourceRequest() with your check below? It would be good to get rid of
this iOS specific code.


More information about the webkit-reviews mailing list