[webkit-reviews] review denied: [Bug 134795] [iOS] Pasting rich content does not perform a two-step paste : [Attachment 234687] Patch

Wed Jul 9 21:24:53 PDT 2014

Benjamin Poulain <benjamin at webkit.org> has denied Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 134795: [iOS] Pasting rich content does not perform a two-step paste
https://bugs.webkit.org/show_bug.cgi?id=134795

Attachment 234687: Patch
https://bugs.webkit.org/attachment.cgi?id=234687&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=234687&action=review

> Source/WebCore/platform/ios/PlatformPasteboardIOS.mm:160
> +	   static NSString* webIOSPastePboardType = @"iOS rich content paste
pasteboard type";

No need for static here :-D

> LayoutTests/platform/ios-sim/editing/pasteboard/two-step-paste.html:8
> +	   var explanation = "The following test does a copy and a paste of
contenteditable content. It then makes sure that the paste involved a two-step
paste. The mechanism it uses to verify this is to determine if some styles
change appropriately. If this test passes you should see the word Pass here
===>";

Let's use the test functions. Then the explanation can be added with
description(explanation)

> LayoutTests/platform/ios-sim/editing/pasteboard/two-step-paste.html:35
> +<body id="b" onload="runTest()" dir="auto" contenteditable="true"
style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break:
after-white-space;">
> +<div id="e">

Let's use better id.

> LayoutTests/platform/ios-sim/editing/pasteboard/two-step-paste.html:48
> +<h2 class="story-heading" style="margin: 0px 0px 2px; font-style: italic;
-webkit-text-size-adjust: 100%; word-spacing: -0.1em; line-height: 1.75rem;
letter-spacing: 0.01em; font-size: 1.625rem; font-family: nyt-cheltenham,
georgia, 'times new roman', times, serif; color: rgb(51, 51, 51);">
> +<a
href="http://www.nytimes.com/2014/07/10/world/asia/chinese-hackers-pursue-key-d
ata-on-us-workers.html" style="text-decoration: none; color: rgb(0, 0,
0);">Hackers in China Pursue Key Data on U.S. Workers
> +</a>
> +</h2>
> +<p class="byline" style="margin: 4px 0px 1px; -webkit-text-size-adjust:
100%; line-height: 0.75rem; font-size: 0.625rem; font-family: georgia, 'times
new roman', times, serif; color: rgb(153, 153, 153);">By MICHAEL S. SCHMIDT,
DAVID E. SANGER and NICOLE PERLROTH&nbsp;
> +<time id="t" class="timestamp" datetime="2014-07-09"
data-eastern-timestamp="9:24 PM" data-utc-timestamp="1404955467"
style="margin-left: 0.1em; white-space: nowrap; line-height: 0.6875rem;
font-size: 0.625rem; font-family: nyt-franklin, arial, helvetica, sans-serif;
color: rgb(168, 24, 23);">9:24 PM ET
> +</time>
> +</p>
> +<p class="summary" style="margin: 0px; -webkit-text-size-adjust: 100%;
line-height: 1.125rem; font-size: 0.8125rem; font-family: georgia, 'times new
roman', times, serif; color: rgb(51, 51, 51);">The hackers penetrated the
system that houses the personal information of all federal employees and
appeared to be&nbsp;
> +</p>
> +<br>Sent from my iPad

Let's nuke the original content and create some simpler content.