[webkit-reviews] review granted: [Bug 134779] Support transparent WKWebViews : [Attachment 234659] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 134779: Support transparent WKWebViews
https://bugs.webkit.org/show_bug.cgi?id=134779

Attachment 234659: Patch
https://bugs.webkit.org/attachment.cgi?id=234659&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234659&action=review


> Source/WebCore/ChangeLog:9
> +	   Schedule rebuilding the compositing layers if a FrameView's
transparency changes.

this definitely needs a "why" (though I vaguely remember from you showing me)

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1173
> +    BOOL oldOpaque = self.opaque;

s/old/was/g?

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1176
> +    [super setOpaque:opaque];
> +    [_contentView setOpaque:opaque];

why are these before the early return?