[webkit-reviews] review granted: [Bug 134386] Fire connected/disconnected events for Gamepads : [Attachment 234638] Patch v1a - Rebased, ready to EWS

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 134386: Fire connected/disconnected events for Gamepads
https://bugs.webkit.org/show_bug.cgi?id=134386

Attachment 234638: Patch v1a - Rebased, ready to EWS
https://bugs.webkit.org/attachment.cgi?id=234638&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234638&action=review


> Source/WebCore/ChangeLog:20
> +	   * Modules/gamepad/GamepadManager.cpp:
> +	   (WebCore::navigatorGamepadFromDOMWindow): Handling converting a
possibly-null Navigator into
> +	     a possibly null NavigatorGamepad.
> +	   (WebCore::GamepadManager::platformGamepadConnected): Notify blind
Navigator/DOMWindows of all
> +	     previously attached Gamepads, then notify everybody of this new
gamepad.
> +	   (WebCore::GamepadManager::platformGamepadDisconnected): Handle
dispatching the disconnected
> +	     event to all registered DOMWindows.
> +	   (WebCore::GamepadManager::platformGamepadInputActivity): Notify
blind Navigator/DOMWindows of all
> +	     attached Gamepads.
> +	   (WebCore::GamepadManager::makeGamepadVisible): Handles notifying
setting up a new gamepads
> +	     with all NavigatorGamepads as well as dispatching the connected
even to DOMWindows.

Nit on your indentation there.

> Source/WebCore/Modules/gamepad/GamepadManager.cpp:74
> +    // Notify everyone of this new gamepad

Nit: missing .