[webkit-reviews] review granted: [Bug 134771] Implement Editor::fontAttributesForSelectionStart() or iOS : [Attachment 234650] Patch2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 9 12:08:13 PDT 2014
Ryosuke Niwa <rniwa at webkit.org> has granted Enrica Casucci <enrica at apple.com>'s
request for review:
Bug 134771: Implement Editor::fontAttributesForSelectionStart() or iOS
https://bugs.webkit.org/show_bug.cgi?id=134771
Attachment 234650: Patch2
https://bugs.webkit.org/attachment.cgi?id=234650&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=234650&action=review
> Source/WebCore/editing/ios/EditorIOS.mm:264
> + if (style->font().primaryFont()->getCTFont())
> + [result setObject:(id)style->font().primaryFont()->getCTFont()
forKey:NSFontAttributeName];
We should store it in a local variable inside if () instead of calling
getCTFont() twice,
More information about the webkit-reviews
mailing list