[webkit-reviews] review granted: [Bug 134731] Make SharedBuffer::append(SharedBuffer*) be smarter about CFData and data arrays : [Attachment 234587] Patch with build fix

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Pratik Solanki
<psolanki at apple.com>'s request for review:
Bug 134731: Make SharedBuffer::append(SharedBuffer*) be smarter about CFData
and data arrays
https://bugs.webkit.org/show_bug.cgi?id=134731

Attachment 234587: Patch with build fix
https://bugs.webkit.org/attachment.cgi?id=234587&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=234587&action=review


> Source/WebCore/ChangeLog:20
> +2014-07-08  Pratik Solanki  <psolanki at apple.com>
> +
> +	   Make SharedBuffer::append(SharedBuffer*) be smarter about CFData and
data arrays
> +	   https://bugs.webkit.org/show_bug.cgi?id=134731
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   No new tests because no functional changes.
> +
> +	   * platform/SharedBuffer.cpp:
> +	   (WebCore::SharedBuffer::append):
> +	   (WebCore::SharedBuffer::maybeAppendPlatformData):
> +	   * platform/SharedBuffer.h:
> +	   * platform/cf/SharedBufferCF.cpp:
> +	   (WebCore::SharedBuffer::maybeAppendPlatformData):
> +	   (WebCore::SharedBuffer::maybeAppendDataArray):
> +	   * platform/soup/SharedBufferSoup.cpp:
> +	   (WebCore::SharedBuffer::maybeAppendPlatformData):
> +
> +2014-07-08  Pratik Solanki  <psolanki at apple.com>

Two change logs. You could mention how it is smarter.