[webkit-reviews] review granted: [Bug 134768] [MSE] http/tests/media/media-source/mediasource-remove.html is failing : [Attachment 234641] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 134768: [MSE] http/tests/media/media-source/mediasource-remove.html is
failing
https://bugs.webkit.org/show_bug.cgi?id=134768

Attachment 234641: Patch
https://bugs.webkit.org/attachment.cgi?id=234641&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234641&action=review


> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:579
> +	   // and the next sync sample frame are removed. But we must start
from the first sample in decode order, not
> +	   // presentation order.

Having this comment just before the code that calculates and compares
removePresentationStart really confused me at first. Maybe put it after?