[webkit-reviews] review denied: [Bug 134759] [EFL][WK2] Add new Public API in ewk_download_job.h to get length of the data already downloaded : [Attachment 234627] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at webkit.org> has denied Shivakumar J M
<shiva.jm at samsung.com>'s request for review:
Bug 134759: [EFL][WK2] Add new Public API in ewk_download_job.h to get length
of the data already downloaded
https://bugs.webkit.org/show_bug.cgi?id=134759

Attachment 234627: Patch
https://bugs.webkit.org/attachment.cgi?id=234627&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=234627&action=review


> Source/WebKit2/UIProcess/API/efl/ewk_download_job.h:193
> +EAPI uint64_t ewk_download_get_received_data_length(const Ewk_Download_Job
*download);

Missing API test for this new API.

And also, looks wrong API naming. Generally verb is placed at the end of
function name in EFL function.

For example,
ewk_download_received_data_length_get()