[webkit-reviews] review granted: [Bug 128968] [XHR] overrideMimeType() should be able to change encoding in HEADERS RECEIVED state : [Attachment 234482] Updated php script and FIXME

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 128968: [XHR] overrideMimeType() should be able to change encoding in
HEADERS RECEIVED state
https://bugs.webkit.org/show_bug.cgi?id=128968

Attachment 234482: Updated php script and FIXME
https://bugs.webkit.org/attachment.cgi?id=234482&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=234482&action=review


> Source/WebCore/xml/XMLHttpRequest.cpp:1143
> +    // FIXME: should we update "Content-Type" header with m_mimeTypeOverride
value in case it has changed since didReceiveResponse?

Please replace "header" with "header field", to make terminology correct.

Also, we usually start FIXME comment with an upper case letter (so it should be
"FIXME: Should...")