[webkit-reviews] review granted: [Bug 134599] [iOS] user caption preferences not applied : [Attachment 234593] Proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 8 20:34:23 PDT 2014


Sam Weinig <sam at webkit.org> has granted Eric Carlson <eric.carlson at apple.com>'s
request for review:
Bug 134599: [iOS] user caption preferences not applied
https://bugs.webkit.org/show_bug.cgi?id=134599

Attachment 234593: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=234593&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=234593&action=review


> Source/WebCore/page/CaptionUserPreferences.cpp:256
> +	      
pageUserContentController->addUserStyleSheet(mainThreadNormalWorld(),
std::move(userStyleSheet), InjectInExistingDocuments);

I don't think you need to explicitly use std::move here.


More information about the webkit-reviews mailing list