[webkit-reviews] review granted: [Bug 130772] [WTF] Add the move constructor, move assignment operator for HashTable : [Attachment 234576] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 130772: [WTF] Add the move constructor, move assignment operator for
HashTable
https://bugs.webkit.org/show_bug.cgi?id=130772

Attachment 234576: Patch
https://bugs.webkit.org/attachment.cgi?id=234576&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234576&action=review


I must admit I still don’t understand where this code will be used. Can you
give an example of a source line that will end up calling this? Anders pointer
out that we already have HashMap and HashSet move constructors and assignment
operators.

> Source/WTF/wtf/HashTable.h:1205
> +	   other.m_stats = nullptr;

This line of code isn’t needed. Moving out of the unique_ptr will null it out.

> Source/WTF/wtf/HashTable.h:1229
> +	   other.m_stats = nullptr;

This line of code isn’t needed. Moving out of the unique_ptr will null it out.