[webkit-reviews] review granted: [Bug 134745] [Win] Implement auto-version as a Perl program : [Attachment 234605] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 134745: [Win] Implement auto-version as a Perl program
https://bugs.webkit.org/show_bug.cgi?id=134745

Attachment 234605: Patch
https://bugs.webkit.org/attachment.cgi?id=234605&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=234605&action=review


r=me

> WebKitLibraries/win/tools/scripts/auto-version.pl:98
> +my $VARIANT_VERSION =$BUILD_TINY_VERSION;

Nit:  Space after '='.

> WebKitLibraries/win/tools/scripts/auto-version.pl:104
> +if (!defined $ENVIRONMENT_VERSION) {

Technically, the equivalent to "-z" would be:

if (!$ENVIRONMENT_VERSION) {

Not sure if that matters.  (Defined returns true if the string is empty, but
"!" will not, IIRC.)