[webkit-reviews] review granted: [Bug 134709] Remove WebBackForwardListItems when their owning page goes away : [Attachment 234602] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 8 15:55:11 PDT 2014


mitz at webkit.org <mitz at webkit.org> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 134709: Remove WebBackForwardListItems when their owning page goes away
https://bugs.webkit.org/show_bug.cgi?id=134709

Attachment 234602: patch
https://bugs.webkit.org/attachment.cgi?id=234602&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=234602&action=review


> Source/WebKit2/WebProcess/WebPage/WebBackForwardListProxy.cpp:107
> +    ItemAndPageID ids;
> +    ids.itemID = itemID;
> +    ids.pageID = pageID;
> +    
> +    historyItemToIDMap().set(item, ids);

Isn’t there a way to do this without the named variable?

> Source/WebKit2/WebProcess/WebPage/WebBackForwardListProxy.cpp:166
> +    historyItemToIDMap().set(item, ids);

Ditto.


More information about the webkit-reviews mailing list