[webkit-reviews] review granted: [Bug 134742] [ftlopt] Phantom simplification should be in its own phase : [Attachment 234594] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 8 15:37:40 PDT 2014


Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 134742: [ftlopt] Phantom simplification should be in its own phase
https://bugs.webkit.org/show_bug.cgi?id=134742

Attachment 234594: the patch
https://bugs.webkit.org/attachment.cgi?id=234594&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234594&action=review


r=me

> Source/JavaScriptCore/dfg/DFGCleanUpPhase.cpp:43
> +class CleanUpPhase : public Phase {
> +public:
> +    CleanUpPhase(Graph& graph)
> +	   : Phase(graph, "clean-up")

Would be nice to specify what we're cleaning up. PhantomCleanUpPhase?


More information about the webkit-reviews mailing list