[webkit-reviews] review canceled: [Bug 134597] Convert fast/css/text-overflow-ellipsis* layout tests to reftests : [Attachment 234560] Path proposal

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has canceled Mario Sanchez Prada
<mario at webkit.org>'s request for review:
Bug 134597: Convert fast/css/text-overflow-ellipsis* layout tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=134597

Attachment 234560: Path proposal
https://bugs.webkit.org/attachment.cgi?id=234560&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
(In reply to comment #2)
> (From update of attachment 234560 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=234560&action=review
> 
> > LayoutTests/fast/css/text-overflow-ellipsis-expected.html:18
> > +.forcertl {
> > +	 direction: rtl;
> > +	 unicode-bidi: bidi-override;
> > +}
> 
> I don't think we should be relying on UBA in the expected result for this
test given where ellipses will be drawn will be affected by UBA itself.
> Reorder the content manually instead.
> 
Good point. Attaching now a new patch following that suggestion.

> > LayoutTests/fast/css/text-overflow-ellipsis-strict-expected.html:18
> > +	 direction: rtl;
> > +	 unicode-bidi: bidi-override;
> 
> Ditto.