[webkit-reviews] review granted: [Bug 134701] [UI-side compositing] Support reflections on custom layers like video : [Attachment 234525] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 134701: [UI-side compositing] Support reflections on custom layers like
video
https://bugs.webkit.org/show_bug.cgi?id=134701

Attachment 234525: Patch
https://bugs.webkit.org/attachment.cgi?id=234525&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234525&action=review


> Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm:183
> +    if ([layer isKindOfClass:[NSClassFromString(@"WebGLLayer") class]])

we talked about this

> Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm:221
> +	   // We don't create PlatformCALayerMac's wrapped around WebGLLayers.

weird apostrophe

> Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h:50
> +    PlatformCALayerRemoteCustom(WebCore::PlatformCALayer::LayerType,
PlatformLayer*, WebCore::PlatformCALayerClient* owner,
RemoteLayerTreeContext&);

star's on the wrong side