[webkit-reviews] review granted: [Bug 134684] ServicesOverlayController menus show up in the wrong place : [Attachment 234499] Patch v2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 7 11:41:32 PDT 2014
Tim Horton <thorton at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 134684: ServicesOverlayController menus show up in the wrong place
https://bugs.webkit.org/show_bug.cgi?id=134684
Attachment 234499: Patch v2
https://bugs.webkit.org/attachment.cgi?id=234499&action=review
------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234499&action=review
> Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:435
> + Page* page = m_webPage->corePage();
Please use WebPage::mainFrameView() instead of all of this.
More information about the webkit-reviews
mailing list