[webkit-reviews] review requested: [Bug 134684] ServicesOverlayController menus show up in the wrong place : [Attachment 234496] Patch v1

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has asked  for review:
Bug 134684: ServicesOverlayController menus show up in the wrong place
https://bugs.webkit.org/show_bug.cgi?id=134684

Attachment 234496: Patch v1
https://bugs.webkit.org/attachment.cgi?id=234496&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234496&action=review


> Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:434
> +void ServicesOverlayController::handleClick(const WebCore::IntPoint&
clickPoint)

This seems wrong. The incoming point is always in a consistent coordinate space
(though I'm not sure at the moment which one), not dependent on what frame you
click on. Am I wrong and this somehow actually works in subframes?