[webkit-reviews] review granted: [Bug 134672] [Mac] No need to paint focus ring if paintRect is completely contained : [Attachment 234474] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 134672: [Mac] No need to paint focus ring if paintRect is completely
contained
https://bugs.webkit.org/show_bug.cgi?id=134672

Attachment 234474: Patch
https://bugs.webkit.org/attachment.cgi?id=234474&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234474&action=review


What if a focus ring rectangle intersects, but does not contain, the painting
rect? For example, consider that a small thin line might be at the top of a
text field input element, in front of it, and that line could change color.
This seems OK, but I think it could leave the focus ring damaged in cases like
that. I think that this function should use enclosingIntRect and intersects.

> Source/WebCore/rendering/RenderObject.cpp:1019
> +    IntRect paintRect(paintInfo.rect);

Why truncate rather than using enclosingIntRect, enclosedIntRect, or
roundedIntRect?