[webkit-reviews] review denied: [Bug 134634] Turn on img at sizes compile flag : [Attachment 234408] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 4 12:36:35 PDT 2014


Dean Jackson <dino at apple.com> has denied Yoav Weiss <yoav at yoav.ws>'s request
for review:
Bug 134634: Turn on img at sizes compile flag
https://bugs.webkit.org/show_bug.cgi?id=134634

Attachment 234408: Patch
https://bugs.webkit.org/attachment.cgi?id=234408&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
Alas, you need to do a bit more than this to turn it on by default. All you are
doing here is toggling it to be on by default build-webkit, but not everyone
uses this.

You should look at the patches that change FeatureDefines.xcconfig (which
covers Apple's ports) as well as other configs for the remaining ports.


More information about the webkit-reviews mailing list