[webkit-reviews] review granted: [Bug 134486] [EFL][WK2] Minibrowser: Enhance the application to show text search count : [Attachment 234326] Patch-Updated-Review2

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at webkit.org> has granted Shivakumar J M
<shiva.jm at samsung.com>'s request for review:
Bug 134486: [EFL][WK2] Minibrowser: Enhance the application to show text search
count
https://bugs.webkit.org/show_bug.cgi?id=134486

Attachment 234326: Patch-Updated-Review2
https://bugs.webkit.org/attachment.cgi?id=234326&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=234326&action=review


LGTM except for nits.

> Tools/MiniBrowser/efl/main.c:1700
> +    const int *matchCount = (const int *)(event_info);

matchCount is not efl style. match_count ?

> Tools/MiniBrowser/efl/main.c:1963
> +    evas_object_smart_callback_add(window->ewk_view, "text,found",
on_search_text_found, window);

Personally I prefer to place it alphabetically.