[webkit-reviews] review granted: [Bug 134619] [iOS WK2] Compositing layers draw outside page bounds : [Attachment 234381] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 134619: [iOS WK2] Compositing layers draw outside page bounds
https://bugs.webkit.org/show_bug.cgi?id=134619

Attachment 234381: Patch
https://bugs.webkit.org/attachment.cgi?id=234381&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=234381&action=review


> Source/WebKit2/UIProcess/ios/WKContentView.mm:570
> +    [_fixedClippingView setPosition:clippingBounds.location()];

UIView's setPosition is deprecated API

> Source/WebKit2/UIProcess/ios/WKContentView.mm:704
> +	   FloatRect fixedPositionRect =
_page->computeCustomFixedPositionRect(_page->unobscuredContentRect(),
[[_webView scrollView] zoomScale]);

I think I'd prefere m_webPageProxy.displayedContentScale() here to be
consistent with RemoteScrollingCoordinatorProxy::customFixedPositionRect().
I don't feel strongly about this, they should be the same values, do as you
prefer.