[webkit-reviews] review granted: [Bug 134545] input type=range element should only fire change events after committing a value : [Attachment 234348] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted pom at graougraou.com's request for
review:
Bug 134545: input type=range element should only fire change events after
committing a  value
https://bugs.webkit.org/show_bug.cgi?id=134545

Attachment 234348: Patch
https://bugs.webkit.org/attachment.cgi?id=234348&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234348&action=review


Congratulations. I think this could be the first sibling to commit a patch to
WebKit! Just upload the final patch and I'll commit it.

> Source/WebCore/ChangeLog:10
> +	   A "change" event was fired every time the slider thumb element was
dragged
> +	   by the user. The "change" event is now fired only after the thumb
> +	   element has stopped moving.

Could you add another paragraph that explains this behaviour matches Firefox
and Chrome? I expect we might get random regression reports from this, and it
would be good for our bug screeners to know right away that this is correct
behaviour (e.g. you noticed that our own media controls were incorrect).