[webkit-reviews] review granted: [Bug 133395] Web Inspector: debugger should be able to show variable types : [Attachment 234237] patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 133395: Web Inspector: debugger should be able to show variable types
https://bugs.webkit.org/show_bug.cgi?id=133395

Attachment 234237: patch
https://bugs.webkit.org/attachment.cgi?id=234237&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234237&action=review


R=me, but can you post a new patch to a different bug, and also fix the one
indentation issue?

> Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.h:584
> +	   public:

You don't need this.  Struct members are public by default.  Also, ordinarily
this wouldn't be indented.  Example:

class Foo {
public:
    int m_bar;
}

Notice how "public:" aligns with "class".

> Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.h:586
> +	       unsigned m_startDivot;
> +	       unsigned m_endDivot;

Deindent by four spaces.