[webkit-reviews] review denied: [Bug 134589] [GTK] Use the same default options for production builds that previous stable releases : [Attachment 234339] This should apply now

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 134589: [GTK] Use the same default options for production builds that
previous stable releases
https://bugs.webkit.org/show_bug.cgi?id=134589

Attachment 234339: This should apply now
https://bugs.webkit.org/attachment.cgi?id=234339&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=234339&action=review


Looks good, but we need to make accelerated canvas support conditional on
CairoGL.

> Source/cmake/OptionsGTK.cmake:68
> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCELERATED_2D_CANVAS ON)

This should be determined by whether or not you have CairoGL support. The
default should probably be off.

> Tools/Scripts/webkitperl/FeatureList.pm:158
> -	 define => "ENABLE_ACCELERATED_2D_CANVAS", default => 0, value =>
\$accelerated2DCanvasSupport },
> +	 define => "ENABLE_ACCELERATED_2D_CANVAS", default => isGtk(), value =>
\$accelerated2DCanvasSupport },

I think this is going to fail unless Cairo with GL support is installed. This
isn't the typical installation on most systems.