[webkit-reviews] review granted: [Bug 129313] Ellipsis is not properly placed for truncated text inside blocks with horizontal border or padding : [Attachment 234336] Patch proposal

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Mario Sanchez Prada
<mario at webkit.org>'s request for review:
Bug 129313: Ellipsis is not properly placed for truncated text inside blocks
with horizontal border or padding
https://bugs.webkit.org/show_bug.cgi?id=129313

Attachment 234336: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=234336&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234336&action=review


> Source/WebCore/rendering/RenderBlockLineLayout.cpp:1843
> +		   float snappedLogicalLeft =
logicalLeftOffsetForLine(curr->lineTop(), firstLine);

I don’t understand why this local variable has the word “snapped” in it. Is it
pixel snapped? I thought that generally layout did not do pixel snapping,
rather painting did.