[webkit-reviews] review denied: [Bug 134560] Buffer CSS and JS resources in network process before sending over to web process : [Attachment 234299] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Pratik Solanki
<psolanki at apple.com>'s request for review:
Bug 134560: Buffer CSS and JS resources in network process before sending over
to web process
https://bugs.webkit.org/show_bug.cgi?id=134560

Attachment 234299: Patch
https://bugs.webkit.org/attachment.cgi?id=234299&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=234299&action=review


Looks like a good idea, assuming that it doesn't break progress events or
resource load timing or Web Inspector (which are all too involved for me to
assess at the moment, but at least tests pass).

> Source/WebKit2/NetworkProcess/NetworkResourceLoader.h:199
> +    RefPtr<WebCore::SharedBuffer> m_bufferedData;

It seems super unfortunate that sync loads collect the data in
SynchronousNetworkLoaderClient object, but all loads have a data member in
NetworkResourceLoader.

I think that this should be designed in a uniform way, definitely without
having multiple instances of the data member.