[webkit-reviews] review granted: [Bug 134582] [iOS][WK2] Fix small bugs of dynamicViewportSizeUpdate that were causing inaccuracies in the computed target : [Attachment 234310] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 134582: [iOS][WK2] Fix small bugs of dynamicViewportSizeUpdate that were
causing inaccuracies in the computed target
https://bugs.webkit.org/show_bug.cgi?id=134582

Attachment 234310: Patch
https://bugs.webkit.org/attachment.cgi?id=234310&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234310&action=review


> Source/WebKit2/ChangeLog:16
> +	   The first issue is that the unobscured content size was stored on
integer coordinates. Because of that, it was

"on" should be "in"

> Source/WebKit2/ChangeLog:21
> +	   on floating point. Since ARM64 does all those computation on double
in the UIProcess, the value would be quite

computation*s* and double*s*

> Source/WebKit2/ChangeLog:27
> +	   valid to have an exposed rect outside the page bounds, that areas is
just under the obscured insets.

area, not areas