[webkit-reviews] review denied: [Bug 134508] In needs FTL implementation : [Attachment 234203] Added In to the FTL

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has denied Matthew Mirman <mmirman at apple.com>'s
request for review:
Bug 134508: In needs FTL implementation
https://bugs.webkit.org/show_bug.cgi?id=134508

Attachment 234203: Added In to the FTL
https://bugs.webkit.org/attachment.cgi?id=234203&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234203&action=review


Add a test for the generic In case and change the sizeOfCheckIn.  Otherwise
LGTM!

> Source/JavaScriptCore/ftl/FTLInlineCacheSize.cpp:70
> +#if CPU(ARM64)
> +    return 44; // TODO: I DON'T YET KNOW WHAT TO PUT HERE
> +#else
> +    return 32; // TODO: I DON'T YET KNOW WHAT TO PUT HERE 
> +#endif

In general, you should put the smallest value that doesn't result in a crash. 
In this case it's just the size of a patchable jump, which on x86 is 5 and on
ARM is 4.