[webkit-reviews] review granted: [Bug 134521] iOS should use shared code to determine the system marketing version : [Attachment 234214] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 2 14:46:25 PDT 2014


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Mark Rowe (bdash)
<mrowe at apple.com>'s request for review:
Bug 134521: iOS should use shared code to determine the system marketing
version
https://bugs.webkit.org/show_bug.cgi?id=134521

Attachment 234214: Patch
https://bugs.webkit.org/attachment.cgi?id=234214&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234214&action=review


> Source/WebCore/page/cocoa/UserAgent.mm:38
> +    return [systemMarketingVersion()
stringByReplacingOccurrencesOfString:@"." withString:@"_"];

It's sad that we go from String to NSString* and back here.


More information about the webkit-reviews mailing list