[webkit-reviews] review granted: [Bug 134518] [ftlopt] Allocate a new GetterSetter if we change the value of any of its entries other than when they were previously null, so that if we constant-infer an accessor slot then we immediately get the function constant for free : [Attachment 234239] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 2 13:58:18 PDT 2014


Mark Hahnenberg <mhahnenberg at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 134518: [ftlopt] Allocate a new GetterSetter if we change the value of any
of its entries other than when they were previously null, so that if we
constant-infer an accessor slot then we immediately get the function constant
for free
https://bugs.webkit.org/show_bug.cgi?id=134518

Attachment 234239: the patch
https://bugs.webkit.org/attachment.cgi?id=234239&action=review

------- Additional Comments from Mark Hahnenberg <mhahnenberg at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234239&action=review


r=me

> Source/JavaScriptCore/ChangeLog:9
> +	   setSetter/setGetter were already allocating a branch new
GetterSetter. But once we start

a brand new


More information about the webkit-reviews mailing list