[webkit-reviews] review denied: [Bug 134506] [iOS][WK2] Sometimes the swipe snapshot stays up too long : [Attachment 234202] actually different patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Tim Horton
<thorton at apple.com>'s request for review:
Bug 134506: [iOS][WK2] Sometimes the swipe snapshot stays up too long
https://bugs.webkit.org/show_bug.cgi?id=134506

Attachment 234202: actually different patch
https://bugs.webkit.org/attachment.cgi?id=234202&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234202&action=review


Too many confusing uint64_ts.

> Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.h:226
> +    Vector<uint64_t> m_callbackIDs;

Typedef for the uint64_t? Is this a pageID or a transactionID or something
else? If a pageID, this member should say m_pageCallbacks or something.

> Source/WebKit2/UIProcess/ios/ViewGestureControllerIOS.mm:70
> +    static NeverDestroyed<HashMap<uint64_t, WebKit::ViewGestureController*>>
viewGestureControllers;

Would be nice if we had a pageID typedef.