[webkit-reviews] review granted: [Bug 133997] Web Inspector: Hexadecimal color values in all CSS editors are purple when they should be blue : [Attachment 234210] [PATCH] Attempted fix with cleanup.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 1 16:17:13 PDT 2014


Joseph Pecoraro <joepeck at webkit.org> has granted Jonathan Wells
<jonowells at apple.com>'s request for review:
Bug 133997: Web Inspector: Hexadecimal color values in all CSS editors are
purple when they should be blue
https://bugs.webkit.org/show_bug.cgi?id=133997

Attachment 234210: [PATCH] Attempted fix with cleanup.
https://bugs.webkit.org/attachment.cgi?id=234210&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=234210&action=review


Awesome! r=me

> Source/WebInspectorUI/UserInterface/Views/CodeMirrorAdditions.js:185
> +	   const hexColorRegex = /(#[0-9a-fA-F]{6}|#[0-9a-fA-F]{3})\b/g;

Nit: I think we still want at least the (?:...) non-capture group. As that can
be a performance win with Regexs.


More information about the webkit-reviews mailing list