[webkit-reviews] review granted: [Bug 134514] Debugger's breakpoint list should not be a Vector : [Attachment 234208] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 1 15:45:44 PDT 2014


Geoffrey Garen <ggaren at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 134514: Debugger's breakpoint list should not be a Vector
https://bugs.webkit.org/show_bug.cgi?id=134514

Attachment 234208: the patch
https://bugs.webkit.org/attachment.cgi?id=234208&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234208&action=review


r=me

> Source/JavaScriptCore/debugger/Breakpoint.h:56
> +    Breakpoint(Breakpoint& other)

Should be const&.


More information about the webkit-reviews mailing list