[webkit-reviews] review granted: [Bug 134512] AX: [iOS WebKit2] Support for Speak selection : [Attachment 234199] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 134512: AX: [iOS WebKit2] Support for Speak selection
https://bugs.webkit.org/show_bug.cgi?id=134512

Attachment 234199: patch
https://bugs.webkit.org/attachment.cgi?id=234199&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234199&action=review


> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1371
> +    _page->getSelectionOrContentsAsString([self](const String& string,
CallbackBase::Error error) {
> +	   if (error != CallbackBase::Error::None)
> +	       return;
> +	   if ([self
respondsToSelector:@selector(accessibilitySpeakSelectionSetContent:)])
> +	       [self accessibilitySpeakSelectionSetContent:string];
> +    });

Is there a guarantee we won’t get the callback after self is deallocated? Do we
need to retain/release self?

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1372
> +

Stray blank line.