[webkit-reviews] review granted: [Bug 130756] [ftlopt] DFG bytecode parser should turn PutById with nothing but a Setter stub as stuff+handleCall, and handleCall should be allowed to inline if it wants to : [Attachment 234193] the patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 130756: [ftlopt] DFG bytecode parser should turn PutById with nothing but a
Setter stub as stuff+handleCall, and handleCall should be allowed to inline if
it wants to
https://bugs.webkit.org/show_bug.cgi?id=130756

Attachment 234193: the patch
https://bugs.webkit.org/attachment.cgi?id=234193&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234193&action=review


> Source/JavaScriptCore/tests/stress/weird-setter-counter.js:20
> +    var o = {};
> +    o.__defineSetter__("f", function(value) {

While it logically shouldn't matter could you also add tests using {set
f(value) { ... }} just to make sure we're not doing anything substantially
different?