[webkit-reviews] review granted: [Bug 134502] Add a encodeLegacySessionState function : [Attachment 234180] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 134502: Add a encodeLegacySessionState function
https://bugs.webkit.org/show_bug.cgi?id=134502

Attachment 234180: Patch
https://bugs.webkit.org/attachment.cgi?id=234180&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234180&action=review


> Source/WebKit2/UIProcess/mac/LegacySessionStateCoding.cpp:406
> +    if (!backForwardListState.currentIndex) {

don't think you want the braces here

> Source/WebKit2/UIProcess/mac/LegacySessionStateCoding.cpp:460
> +    buffer.get()[2] = (sessionStateDataVersion & 0x0000ff0) >> 8;

this doesn't look right! should be 0x0000ff00, no?