[webkit-reviews] review granted: [Bug 128040] IDB: Handle "nextunique" and "prevunique" cursors, and handle "advance()" correctly : [Attachment 222873] Patch v1

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 128040: IDB: Handle "nextunique" and "prevunique" cursors, and handle
"advance()" correctly
https://bugs.webkit.org/show_bug.cgi?id=128040

Attachment 222873: Patch v1
https://bugs.webkit.org/attachment.cgi?id=222873&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222873&action=review


r=me with not even a nit, just a feckless comment:

> Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:213
> +    bool isUnique = m_cursorDirection ==
IndexedDB::CursorDirection::NextNoDuplicate || m_cursorDirection ==
IndexedDB::CursorDirection::PrevNoDuplicate;

This is slightly confusing, but I can't come up with a better solution here,
so.