[webkit-reviews] review requested: [Bug 127586] Add support for ActionSheets in WK2 for iOS : [Attachment 222867] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 31 17:50:30 PST 2014


Enrica Casucci <enrica at apple.com> has asked  for review:
Bug 127586: Add support for ActionSheets in WK2 for iOS
https://bugs.webkit.org/show_bug.cgi?id=127586

Attachment 222867: Updated patch
https://bugs.webkit.org/attachment.cgi?id=222867&action=review

------- Additional Comments from Enrica Casucci <enrica at apple.com>
I agree with Ben's suggestion. It is not a good idea to add a lot of code to
WKInteractionView to handle the action sheet specific tasks.
The new patch has a controller class WKActionSheetAssistant that encapsulates
lifetime management and delegates.


More information about the webkit-reviews mailing list