[webkit-reviews] review granted: [Bug 127910] Avoid eagerly creating the JSActivation when the debugger is attached : [Attachment 222864] the patch.

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 127910: Avoid eagerly creating the JSActivation when the debugger is
attached
https://bugs.webkit.org/show_bug.cgi?id=127910

Attachment 222864: the patch.
https://bugs.webkit.org/attachment.cgi?id=222864&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222864&action=review


> Source/JavaScriptCore/debugger/DebuggerCallFrame.cpp:119
> +	   JSActivation* activation;
> +	   activation = JSActivation::create(*codeBlock->vm(), m_callFrame,
codeBlock);

one line

> Source/JavaScriptCore/interpreter/CallFrameInlines.h:145
> +    ASSERT(codeBlock->needsActivation());

i'm paranoid make this a RELEASE_ASSERT as it doesn't look like it should be
hot and the activation register call will mean you're going to have decent
memory locality